[llvm] r221626 - [X86] Fix pattern match for 32-to-64-bit zext in the presence of AssertSext

Michael Kuperstein michael.m.kuperstein at intel.com
Mon Nov 10 12:40:21 PST 2014


Author: mkuper
Date: Mon Nov 10 14:40:21 2014
New Revision: 221626

URL: http://llvm.org/viewvc/llvm-project?rev=221626&view=rev
Log:
[X86] Fix pattern match for 32-to-64-bit zext in the presence of AssertSext

This fixes an issue with matching trunc -> assertsext -> zext on x86-64, which would not zero the high 32-bits.
See PR20494 for details.

Differential Revision: http://reviews.llvm.org/D6128

Added:
    llvm/trunk/test/CodeGen/X86/TruncAssertZext.ll
Modified:
    llvm/trunk/lib/Target/X86/X86InstrCompiler.td

Modified: llvm/trunk/lib/Target/X86/X86InstrCompiler.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrCompiler.td?rev=221626&r1=221625&r2=221626&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86InstrCompiler.td (original)
+++ llvm/trunk/lib/Target/X86/X86InstrCompiler.td Mon Nov 10 14:40:21 2014
@@ -1191,6 +1191,7 @@ def def32 : PatLeaf<(i32 GR32:$src), [{
   return N->getOpcode() != ISD::TRUNCATE &&
          N->getOpcode() != TargetOpcode::EXTRACT_SUBREG &&
          N->getOpcode() != ISD::CopyFromReg &&
+         N->getOpcode() != ISD::AssertSext &&
          N->getOpcode() != X86ISD::CMOV;
 }]>;
 

Added: llvm/trunk/test/CodeGen/X86/TruncAssertZext.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/TruncAssertZext.ll?rev=221626&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/X86/TruncAssertZext.ll (added)
+++ llvm/trunk/test/CodeGen/X86/TruncAssertZext.ll Mon Nov 10 14:40:21 2014
@@ -0,0 +1,16 @@
+; RUN: llc < %s -O2 -march=x86-64 | FileCheck %s
+; Checks that a zeroing mov is inserted for the trunc/zext pair even when
+; the source of the zext is an AssertSext node
+; PR20494
+
+define i64 @main(i64 %a) { 
+; CHECK-LABEL: main
+; CHECK: movl %ecx, %eax
+; CHECK: ret
+  %or = or i64 %a, -2
+  %trunc = trunc i64 %or to i32
+  br label %l
+l:
+  %ext = zext i32 %trunc to i64
+  ret i64 %ext
+}





More information about the llvm-commits mailing list