[patch] Pass an ArrayRef to MCDisassembler::getInstruction

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Nov 10 10:19:53 PST 2014


The attached patches change  MCDisassembler::getInstruction to take an
ArrayRef<uint8_t> instead of a MemoryObject.

Even on X86 there is a maximum size an instruction can have. Given
that, it seems way simpler and more efficient to just pass an ArrayRef
to the disassembler instead of a MemoryObject and have it do a virtual
call every time it wants some extra bytes.

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm.patch
Type: text/x-patch
Size: 32192 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141110/21c4b33e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lldb.patch
Type: text/x-patch
Size: 1467 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141110/21c4b33e/attachment-0001.bin>


More information about the llvm-commits mailing list