[PATCH] [MSan] [MIPS] Adding support for MIPS64

Mohit Bhakkad mohit.bhakkad at imgtec.com
Sun Nov 9 22:32:45 PST 2014


================
Comment at: lib/msan/msan.h:35
@@ -28,1 +34,3 @@
+  ((uptr)mem >= 0xa000000000ULL && (uptr)mem <= 0xc000000000ULL)
+#else
 #define MEM_TO_SHADOW(mem)       (((uptr)mem) & ~0x400000000000ULL)
----------------
eugenis wrote:
> Please change this to #elif defined(__x86_64__) and an #error if neither is defined.
> The same in msan_allocator.cc and other similar cases.
I will put x86_64 in #elif, but an extra line for #error will be redundant, as control will never come here, as "memory" option is not enabled in clang driver for those architectures.

http://reviews.llvm.org/D5906






More information about the llvm-commits mailing list