[PATCH] [LIT] add executeCommandPTY utility function that executes commands within a pseudo-terminal.

Eric Fiselier eric at efcs.ca
Sun Nov 9 16:37:57 PST 2014


Hi ddunbar, silvas,

Add a utility function that behaves like executeCommand but uses a pseudo-terminal so that commands will usually output color.

This patch addresses @ddunbar's concerns about a full pipe blocking by using constantly reading from the pipes while the process is still running.
This patch does not address @ddunbar's concerns about using a single read command at the end of the process because the python documentation states that that read will return all the data. (let me know if I'm wrong)

http://reviews.llvm.org/D6187

Files:
  utils/lit/lit/util.py
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6187.15964.patch
Type: text/x-patch
Size: 3129 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141110/9e14b0d9/attachment.bin>


More information about the llvm-commits mailing list