[PATCH] Added a new transformation " (sub (or A, B) (and A, B)) --> (xor A, B) "

[suyog sarda]

Hi Sean,

Didn't get the context of your comment (I didn't comment on this thread at
any point of time :).
I think you meant Sonam as she has mentioned in this thread that similar
transformation
exist in VisitAdd()).

Do you want me to do something on this?

I am of the opinion (after working on similar kind of patches earlier) that
there can be n number
of such combinations and there needs to be general combiner for pattern
(Hence, i stopped submitting
such patches these days :) ).

As mentioned earlier by you and Daniel in below thread, this can be
achieved by having a table
of preferred form of expression (may be tblegen can help in this, not sure).

http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-August/075843.html



On Sat, Nov 8, 2014 at 9:31 AM, Sean Silva <chisophugis at gmail.com> wrote:

> Upthread Suyog mentions a "similar" transformation in visitAdd, which was
> added in r155674 referencing a rdar. I'm not sure how Suyog got from that
> transformation to this one though (a script? seems difficult to deduce).
>
> On Thu, Nov 6, 2014 at 10:54 PM, Anton Korobeynikov <
> anton at korobeynikov.info> wrote:
>
>> The question still applies (and actually is very in-line with Hal's
>> comments in D5719) - you need to provide some evidence that such pattern
>> indeed happens in practice (why it's so hard to count how many times it
>> happens in test-suite? after more than month?). And it's not some random
>> stuff which you simple want to commit in due to some reason you do not want
>> to share with us.
>>
>> http://reviews.llvm.org/D5720
>>
>>
>>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>


-- 
With regards,
Suyog Sarda
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141108/5833e47e/attachment.html>