[PATCH] Fix Mach-O unit tests breakage on Windows
Rui Ueyama
ruiu at google.com
Thu Nov 6 19:05:40 PST 2014
Thanks. Committed as r221508.
On Thu, Nov 6, 2014 at 6:51 PM, kledzik at apple.com <kledzik at apple.com> wrote:
> Funny. I just ran into this myself linking libc for arm64. Some of the
> .o files inside static archives are not 8-byte aligned, so the read64() is
> asserting. I think the read64() assert may be too aggressive. It may need
> to fallback to memcpy() for reading unaligned data, rather that asserting.
>
> But this patch is goodness. Mach-O files should be at least 4 or 8 byte
> aligned, and the uint8_t[] does not guarantee that. Please commit this.
>
> http://reviews.llvm.org/D6161
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141106/c16b06a7/attachment.html>
More information about the llvm-commits
mailing list