[llvm] r221454 - Fixing some -Wcast-qual warnings; NFC.

[Eli Bendersky]

On Thu, Nov 6, 2014 at 8:40 AM, Eli Bendersky <eliben at google.com> wrote:

>
>
> On Thu, Nov 6, 2014 at 8:26 AM, David Blaikie <dblaikie at gmail.com> wrote:
>
>>
>>
>> On Thu, Nov 6, 2014 at 6:32 AM, Aaron Ballman <aaron at aaronballman.com>
>> wrote:
>>
>>> Author: aaronballman
>>> Date: Thu Nov  6 08:32:30 2014
>>> New Revision: 221454
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=221454&view=rev
>>> Log:
>>> Fixing some -Wcast-qual warnings; NFC.
>>>
>>> Modified:
>>>     llvm/trunk/lib/Target/NVPTX/NVPTXLowerStructArgs.cpp
>>>
>>> Modified: llvm/trunk/lib/Target/NVPTX/NVPTXLowerStructArgs.cpp
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/NVPTX/NVPTXLowerStructArgs.cpp?rev=221454&r1=221453&r2=221454&view=diff
>>>
>>> ==============================================================================
>>> --- llvm/trunk/lib/Target/NVPTX/NVPTXLowerStructArgs.cpp (original)
>>> +++ llvm/trunk/lib/Target/NVPTX/NVPTXLowerStructArgs.cpp Thu Nov  6
>>> 08:32:30 2014
>>> @@ -64,7 +64,7 @@ void NVPTXLowerStructArgs::handleParam(A
>>>    const Type *StructType = PType->getElementType();
>>>
>>>    AllocaInst *AllocA =
>>> -    new AllocaInst((Type *)StructType, Arg->getName(), FirstInst);
>>> +    new AllocaInst(const_cast<Type *>(StructType), Arg->getName(),
>>> FirstInst);
>>>
>>
>> Why is StructType a const Type* anyway? Types are immutable and we (I)
>> removed const from all references to them years ago...
>>
>>
>
>
> I'm doing a cleanup on this file right now, and will take a look at this
> cast as well.
>
>
Things should look better in r221464.

Eli
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141106/e603d85e/attachment.html>