[PATCH] llvm-symbolizer: teach it about PowerPC64 ELF function descriptors

Jay Foad jay.foad at gmail.com
Thu Nov 6 06:41:33 PST 2014


Inline comment.

================
Comment at: tools/llvm-symbolizer/LLVMSymbolize.cpp:89-90
@@ -71,1 +88,4 @@
     return;
+  uint64_t OpdOffset = SymbolAddress - OpdAddress;
+  if (OpdOffset == (uint32_t)OpdOffset && 
+      OpdExtractor.isValidOffsetForDataOfSize(OpdOffset, 8)) {
----------------
I realise this is a bit ugly. As an alternative I could update DataExtractor::isValidOffset{,ForDataOfSize} to take 64-bit offsets.

http://reviews.llvm.org/D6110






More information about the llvm-commits mailing list