[PATCH] [Sanitizers] Enable stack traces on FreeBSD

Viktor Kutuzov vkutuzov at accesssoftek.com
Thu Nov 6 05:25:54 PST 2014


> Also, won't we have a data race when one thread checks if it wants to use a fast unwind (e.g. to save an alllocation stack), and another thread hits a segfault and invokes a signal handler?

Sure we will. Thanks for the catch.

Since THREADLOCAL is not supported on OSX and Android and thread-associated data is sanitizer-specific, what if we keep this in Asan and move the code that determines whether we are in a deadly signal handler on FreeBSD from WillUseFastUnwind() (sanitizer_common) to GetStackTraceWithPcBpAndContext() (asan_stack), like in this new patch?

http://reviews.llvm.org/D6086

Files:
  lib/asan/asan_posix.cc
  lib/asan/asan_stack.h
  lib/asan/asan_thread.h
  lib/sanitizer_common/sanitizer_stacktrace.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6086.15857.patch
Type: text/x-patch
Size: 3528 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141106/a2ce4b3d/attachment.bin>


More information about the llvm-commits mailing list