[PATCH] [compiler-rt] fix and simplify GetMaxVirtualAddress for ppc64*

Jay Foad jay.foad at gmail.com
Thu Nov 6 01:13:13 PST 2014


Just one more inline comment.

================
Comment at: lib/sanitizer_common/sanitizer_posix.cc:85-86
@@ -84,3 +84,4 @@
   // one of 0x00000fffffffffffUL and 0x00003fffffffffffUL.
   // Note that with 'ulimit -s unlimited' the stack is moved away from the top
   // of the address space, so simply checking the stack address is not enough.
+  // Use helper macros to determine the frame size and handle bit-shifting.
----------------
comment should be tweaked or removed

http://reviews.llvm.org/D6044






More information about the llvm-commits mailing list