[PATCH] Add process name to Asan logfile name and report message

Alexey Samsonov vonosmas at gmail.com
Wed Nov 5 19:02:36 PST 2014


Please fix a couple of things below.

Thanks for working on this!

================
Comment at: lib/sanitizer_common/sanitizer_common.cc:250
@@ -249,1 +249,3 @@
 
+static BlockingMutex proc_self_exe_cache_lock;
+static char proc_self_exe_cache_str[kMaxPathLength];
----------------
This should be proc_self_exe_cache_lock(LINKER_INITIALIZED);

================
Comment at: lib/sanitizer_common/sanitizer_common.cc:268
@@ +267,3 @@
+
+const char *BaseName(const char *name) {
+  const char *base1 = internal_strrchr(name, '/'),
----------------
I think we already have it: StripModuleName().
You may need to fix its implementation.

http://reviews.llvm.org/D5724






More information about the llvm-commits mailing list