[PATCH] [x86 fast-isel] Materialize allocas with the correct-sized lea for ILP32

[Derek Schuff]

================
Comment at: test/CodeGen/X86/x32-alloca.ll:2
@@ +1,3 @@
+; RUN: llc < %s -mtriple=x86_64-linux-gnux32 -fast-isel | FileCheck %s
+; RUN: llc < %s -mtriple=x86_64-nacl -fast-isel | FileCheck %s
+
----------------
jvoung wrote:
> Add "-fast-isel-abort" to make sure it's actually using fast-isel for this codegen?
> 
> A bunch of the other fast-isel tests have a "fast-isel-" prefix for the filename. Perhaps it would be good to stick with that.
> 
> I couldn't find any existing test for this for non ILP32 x86-64 code, so might as well test the non-ILP32 x86-64 code path too. Maybe the test can be merged into fast-isel-x86-64.ll (but only have a check-prefix of this case for x32 for now)?
> 
Added -fast-isel-abort and renamed; unfortunately fast-isel-x86_64.ll can't be codegen'd for x32/nacl currently (it throws an assert). Fixing that would be beyond the scope of this change but I added the same test case to that file for LP64.

================
Comment at: test/CodeGen/X86/x32-alloca.ll:6
@@ +5,3 @@
+
+define void @bar(i32* %arg) {
+  ret void
----------------
jvoung wrote:
> could probably just make bar a "declare" and not have to codegen it
Done.

================
Comment at: test/CodeGen/X86/x32-alloca.ll:17
@@ +16,1 @@
+}
\ No newline at end of file

----------------
rnk wrote:
> please fix
Done.

http://reviews.llvm.org/D6136