[llvm] r220910 - [Mips] Add new Mips specific e_flags.

[Eric Christopher]

Awesome.

-eric

On Tue Nov 04 2014 at 8:06:05 AM Daniel Sanders <Daniel.Sanders at imgtec.com>
wrote:

>  Hi,
>
>
>
> The O32 line needs an extra space but apart from that the alignment is
> only wrong in the email.
>
>
>
> *From:* llvm-commits-bounces at cs.uiuc.edu [mailto:
> llvm-commits-bounces at cs.uiuc.edu] *On Behalf Of *Eric Christopher
> *Sent:* 30 October 2014 21:10
> *To:* Simon Atanasyan
> *Cc:* llvm-commits
> *Subject:* Re: [llvm] r220910 - [Mips] Add new Mips specific e_flags.
>
>
>
> Right, doesn't look like it is aligned either. Could be wrong.
>
> On Thu, Oct 30, 2014, 2:08 PM Simon Atanasyan <simon at atanasyan.com> wrote:
>
> One space between enum and the '=' conforms to our code-style but code
> around the changed lines align '=' in one column. That is why I
> selected such formatting style.
>
> On Fri, Oct 31, 2014 at 12:00 AM, Eric Christopher <echristo at gmail.com>
> wrote:
> > The formatting of the flags is weird. How about just one space between
> the
> > enum and the '='?
> >
> > Thanks.
> >
> > -eric
> >
> > On Thu Oct 30 2014 at 8:12:11 AM Simon Atanasyan <simon at atanasyan.com>
> > wrote:
> >>
> >> Author: atanasyan
> >> Date: Thu Oct 30 09:56:02 2014
> >> New Revision: 220910
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=220910&view=rev
> >> Log:
> >> [Mips] Add new Mips specific e_flags.
> >>
> >> No functional changes.
> >>
> >> Modified:
> >>     llvm/trunk/include/llvm/Support/ELF.h
> >>
> >> Modified: llvm/trunk/include/llvm/Support/ELF.h
> >> URL:
> >>
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/ELF.h?rev=220910&r1=220909&r2=220910&view=diff
> >>
> >>
> ==============================================================================
> >> --- llvm/trunk/include/llvm/Support/ELF.h (original)
> >> +++ llvm/trunk/include/llvm/Support/ELF.h Thu Oct 30 09:56:02 2014
> >> @@ -876,7 +876,13 @@ enum : unsigned {
> >>    EF_MIPS_ABI2      = 0x00000020,
> >>    EF_MIPS_32BITMODE = 0x00000100,
> >>    EF_MIPS_NAN2008   = 0x00000400, // Uses IEE 754-2008 NaN encoding
> >> +
> >> +  // ABI flags
> >>    EF_MIPS_ABI_O32   = 0x00001000, // This file follows the first MIPS
> 32
> >> bit ABI
> >> +  EF_MIPS_ABI_O64    = 0x00002000, // O32 ABI extended for 64-bit
> >> architecture.
> >> +  EF_MIPS_ABI_EABI32 = 0x00003000, // EABI in 32 bit mode.
> >> +  EF_MIPS_ABI_EABI64 = 0x00004000, // EABI in 64 bit mode.
> >> +  EF_MIPS_ABI        = 0x0000f000, // Mask for selecting EF_MIPS_ABI_
> >> variant.
> >>
> >>    //ARCH_ASE
> >>    EF_MIPS_MICROMIPS = 0x02000000, // microMIPS
>
> --
> Simon Atanasyan
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141104/858deab8/attachment.html>