[PATCH] [ARM] Fix ARM triple parsing.

Renato Golin renato.golin at linaro.org
Tue Nov 4 05:25:55 PST 2014


Eric,

>From my point of view, the issue this solves is that now you can say "-triple armvelocipede" and it'll work. That's far from ideal.

I'd prefer to have a proper parser to get arch+cpu+features from triple/march/mcpu/mfpu/mtune options, but that'll require the TargetInfo parser, which will take a while. For now, this patch would at least cover the bogus cases in ARM.

I agree some tests are in order, but I believe we already have some.

Gabor,

Have you checked for current tests on that? Are they complete? Even if they are, we should have at least a few negative tests ("RUN: not" lines) to make sure we don't accept the things we say we won't.

cheers,
--renato

http://reviews.llvm.org/D6058






More information about the llvm-commits mailing list