[PATCH] Change TargetLoweringObjectFile ownership

Eric Christopher echristo at gmail.com
Mon Nov 3 18:56:28 PST 2014


LGTM. Thanks!

Getting to all of the other targets shortly?

-eric

On Mon Nov 03 2014 at 11:46:44 AM Aditya Nandakumar <
aditya_nandakumar at apple.com> wrote:

> Hi Eric
>
> Apologies - I missed your review.
> I have updated the Construction to return unique_ptr and uses make_unique
> as you suggested. I too am not sure how to eliminate the unique_ptr here.
>
> Aditya
>
> http://reviews.llvm.org/D5850
>
> Files:
>   include/llvm/Target/TargetLowering.h
>   lib/CodeGen/TargetLoweringBase.cpp
>   lib/Target/X86/X86ISelLowering.cpp
>   lib/Target/X86/X86TargetMachine.cpp
>   lib/Target/X86/X86TargetMachine.h
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141104/e89692f8/attachment.html>


More information about the llvm-commits mailing list