[PATCH] Fix an issue with certain constants as live values in patchpoints.

Andrew Trick atrick at apple.com
Mon Nov 3 15:51:23 PST 2014


Thanks! Good idea Juergen.
-Andy

> On Nov 3, 2014, at 2:58 PM, Juergen Ributzka <juergen at apple.com> wrote:
> 
> LGTM
> 
> ================
> Comment at: lib/CodeGen/StackMaps.cpp:225
> @@ -224,1 +224,3 @@
>       I->LocType = Location::ConstantIndex;
> +      // ConstPool is intentionally a MapVector of uint64_ts (as
> +      // opposed to int64_ts).  We should never be in a situation
> ----------------
> uint64_ts -> 'uint64_t's
> 
> ================
> Comment at: lib/CodeGen/StackMaps.cpp:230
> @@ -225,1 +229,3 @@
> +      // (uint64_t)0 and (uint64_t)-1.  They can be and are
> +      // represented using 32 bit integers.
>       auto Result = ConstPool.insert(std::make_pair(I->Offset, I->Offset));
> ----------------
> Maybe we should add an assert here to make sure this won't happen in the future.
> 
> http://reviews.llvm.org/D6101
> 
> 





More information about the llvm-commits mailing list