[PATCH] [mips][microMIPS] Mark symbols as microMIPS if necessary

Zoran Jovanovic zoran.jovanovic at imgtec.com
Mon Nov 3 07:40:02 PST 2014


================
Comment at: include/llvm/MC/MCStreamer.h:349
@@ -348,3 +348,3 @@
   /// This corresponds to assembler directives like .section, .text, etc.
-  void SwitchSection(const MCSection *Section,
-                     const MCExpr *Subsection = nullptr) {
+  virtual void SwitchSection(const MCSection *Section,
+                             const MCExpr *Subsection = nullptr) {
----------------
rafael wrote:
> can't you use the already virtual ChangeSection?
ChangeSection is called only if section is actually changed. 
If section in .section  directive is the same as current section then ChangeSection is not called (unlike SwitchSection).
As consequence, test micromips-label-test-sections.s would fail.

http://reviews.llvm.org/D6039






More information about the llvm-commits mailing list