[PATCH] [asan] [mips] added support of asan for mips64/mips64el

Daniel Sanders daniel.sanders at imgtec.com
Mon Nov 3 06:24:32 PST 2014


================
Comment at: lib/asan/asan_allocator.h:107
@@ -105,1 +106,3 @@
+const uptr kAllocatorSpace = 0x4000000000ULL;
+const uptr kAllocatorSize  = 0x4000000000ULL;  // 256GB.
 # else
----------------
kcc wrote:
> Is this enough? 
> As I've asked in http://reviews.llvm.org/D5906, did you verify that this works on
> applications that allocate 8Gb of RAM with the same size class? 
> Or mips machines are not expected to be used with that much RAM? 
> What is the maximal amount of physical RAM in a mips machine for a foreseeable future? 
> As I've asked in http://reviews.llvm.org/D5906, did you verify that this works on applications that allocate 8Gb of RAM with the same size class? 
> Or mips machines are not expected to be used with that much RAM? 
> What is the maximal amount of physical RAM in a mips machine for a foreseeable future?

I can't answer the 'Is this enough?' question but at the moment the biggest machines we have available to test on have 8GB RAM. It seems reasonable to predict that there will be >32GB machines in the not too distant future though.

One other thing to mention is that I've just found out that MIPS64r1 is limited to 36-bit physical addresses (64GB). MIPS64r2 added an extension to provide (up to) 59-bit physical addresses. On both architectures, there is a 64-bit virtual address space of which half is for the kernel and half is for user applications.

http://reviews.llvm.org/D6024






More information about the llvm-commits mailing list