[PATCH] Add CRLF support to LineIterator.

Justin Bogner mail at justinbogner.com
Sun Nov 2 18:24:52 PST 2014


Rafael EspĂ­ndola <rafael.espindola at gmail.com> writes:
>> This can read past the end of the buffer in a few places if the buffer
>> ends with '\r' for some reason. We should probably handle that
>> possibility.
>>
>
> No, the buffer is guaranteed to end with a '\0':
>
>  assert(Buffer.getBufferEnd()[0] == '\0')

You're right, of course. This LGTM.




More information about the llvm-commits mailing list