[PATCH] Embed LLVM version into version field of bitcode wrapper

Sean Silva chisophugis at gmail.com
Fri Oct 31 17:36:15 PDT 2014


There didn't seem to be consensus in the llvmdev thread. You will probably
want to start a new thread and explain a bit better. Talking with you
offline I think there is a good case to be made for this in our use case
which I don't think was being clearly explained.

Regarding the patch, there might be some other comments that need to be
updated too.

Also, is there a reason the patch is darwin-specific? Only the last two
lines of the unit test seem specific to this change. The other stuff seems
like it should be a separate patch.

-- Sean Silva

On Mon, Oct 27, 2014 at 8:11 PM, Yung, Douglas <
douglas_yung at playstation.sony.com> wrote:

>  Any chance that someone could do a quick review for this patch? It’s a
> really simple change!
>
>
>
> Douglas Yung
>
>
>
> *From:* Yung, Douglas
> *Sent:* Tuesday, October 14, 2014 15:30
> *To:* 'llvm-commits at cs.uiuc.edu'
> *Subject:* [PATCH] Embed LLVM version into version field of bitcode
> wrapper
>
>
>
> Hi –
>
>
>
> The attached patch changes the compiler to embed the LLVM major and minor
> version numbers into the version field of the bitcode wrapper. Along with
> this change I have also added a unittest which verifies the correct version
> number has been embedded and updated the documentation on the bitcode
> wrapper.
>
>
>
> Douglas Yung
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141031/3bfbf00c/attachment.html>


More information about the llvm-commits mailing list