[PATCH] [AArch64] CondOpt pass is missing FCMPSri and FCMPDri

Chad Rosier mcrosier at codeaurora.org
Fri Oct 31 07:36:53 PDT 2014


Hi Zhaoshi,
Assuming you address my comments as well as handle all four cases (FCMPDri, FCMPSri, FCMPEDri, FCMPESri) this LGTM.

 Chad

================
Comment at: test/CodeGen/AArch64/combine-comparisons-by-cse.ll:361
@@ +360,3 @@
+
+; CHECK-LABEL: fcmpri
+; CHECK: cmp w0, #2
----------------
Please add : after the function name.

Explicitly,

;  CHECK-LABEL: fcmpri:

================
Comment at: test/CodeGen/AArch64/combine-comparisons-by-cse.ll:385
@@ +384,3 @@
+if.end:                                           ; preds = %land.lhs.true, %entry
+  %call = tail call i32 @zoo(i32 1)
+  %call2 = tail call double @yoo(i32 -1)
----------------
Please remove 'tail' from the call site.

Multiple instances in the test case.

http://reviews.llvm.org/D6047






More information about the llvm-commits mailing list