[llvm] r220929 - llvm-cov: Follow LLVM naming conventions

Justin Bogner mail at justinbogner.com
Thu Oct 30 13:57:50 PDT 2014


Author: bogner
Date: Thu Oct 30 15:57:49 2014
New Revision: 220929

URL: http://llvm.org/viewvc/llvm-project?rev=220929&view=rev
Log:
llvm-cov: Follow LLVM naming conventions

This renames a few things that are using an unusual naming convention.

Modified:
    llvm/trunk/tools/llvm-cov/CodeCoverage.cpp
    llvm/trunk/tools/llvm-cov/TestingSupport.cpp
    llvm/trunk/tools/llvm-cov/gcov.cpp
    llvm/trunk/tools/llvm-cov/llvm-cov.cpp

Modified: llvm/trunk/tools/llvm-cov/CodeCoverage.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/CodeCoverage.cpp?rev=220929&r1=220928&r2=220929&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/CodeCoverage.cpp (original)
+++ llvm/trunk/tools/llvm-cov/CodeCoverage.cpp Thu Oct 30 15:57:49 2014
@@ -473,12 +473,12 @@ int CodeCoverageTool::report(int argc, c
   return 0;
 }
 
-int show_main(int argc, const char **argv) {
+int showMain(int argc, const char *argv[]) {
   CodeCoverageTool Tool;
   return Tool.run(CodeCoverageTool::Show, argc, argv);
 }
 
-int report_main(int argc, const char **argv) {
+int reportMain(int argc, const char *argv[]) {
   CodeCoverageTool Tool;
   return Tool.run(CodeCoverageTool::Report, argc, argv);
 }

Modified: llvm/trunk/tools/llvm-cov/TestingSupport.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/TestingSupport.cpp?rev=220929&r1=220928&r2=220929&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/TestingSupport.cpp (original)
+++ llvm/trunk/tools/llvm-cov/TestingSupport.cpp Thu Oct 30 15:57:49 2014
@@ -21,7 +21,7 @@
 using namespace llvm;
 using namespace object;
 
-int convert_for_testing_main(int argc, const char **argv) {
+int convertForTestingMain(int argc, const char *argv[]) {
   sys::PrintStackTraceOnErrorSignal();
   PrettyStackTraceProgram X(argc, argv);
   llvm_shutdown_obj Y; // Call llvm_shutdown() on exit.

Modified: llvm/trunk/tools/llvm-cov/gcov.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/gcov.cpp?rev=220929&r1=220928&r2=220929&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/gcov.cpp (original)
+++ llvm/trunk/tools/llvm-cov/gcov.cpp Thu Oct 30 15:57:49 2014
@@ -84,7 +84,7 @@ void reportCoverage(StringRef SourceFile
   FI.print(SourceFile, GCNO, GCDA);
 }
 
-int gcov_main(int argc, const char **argv) {
+int gcovMain(int argc, const char *argv[]) {
   // Print a stack trace if we signal out.
   sys::PrintStackTraceOnErrorSignal();
   PrettyStackTraceProgram X(argc, argv);

Modified: llvm/trunk/tools/llvm-cov/llvm-cov.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/llvm-cov.cpp?rev=220929&r1=220928&r2=220929&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/llvm-cov.cpp (original)
+++ llvm/trunk/tools/llvm-cov/llvm-cov.cpp Thu Oct 30 15:57:49 2014
@@ -20,19 +20,19 @@
 using namespace llvm;
 
 /// \brief The main entry point for the 'show' subcommand.
-int show_main(int argc, const char **argv);
+int showMain(int argc, const char *argv[]);
 
 /// \brief The main entry point for the 'report' subcommand.
-int report_main(int argc, const char **argv);
+int reportMain(int argc, const char *argv[]);
 
 /// \brief The main entry point for the 'convert-for-testing' subcommand.
-int convert_for_testing_main(int argc, const char **argv);
+int convertForTestingMain(int argc, const char *argv[]);
 
 /// \brief The main entry point for the gcov compatible coverage tool.
-int gcov_main(int argc, const char **argv);
+int gcovMain(int argc, const char *argv[]);
 
 /// \brief Top level help.
-int help_main(int argc, const char **argv) {
+int helpMain(int argc, const char *argv[]) {
   errs() << "OVERVIEW: LLVM code coverage tool\n\n"
          << "USAGE: llvm-cov {gcov|report|show}\n";
   return 0;
@@ -41,24 +41,23 @@ int help_main(int argc, const char **arg
 int main(int argc, const char **argv) {
   // If argv[0] is or ends with 'gcov', always be gcov compatible
   if (sys::path::stem(argv[0]).endswith_lower("gcov"))
-    return gcov_main(argc, argv);
+    return gcovMain(argc, argv);
 
   // Check if we are invoking a specific tool command.
   if (argc > 1) {
-    typedef int (*MainFunction)(int, const char **);
-    MainFunction func =
-        StringSwitch<MainFunction>(argv[1])
-            .Case("convert-for-testing", convert_for_testing_main)
-            .Case("gcov", gcov_main)
-            .Case("report", report_main)
-            .Case("show", show_main)
-            .Cases("-h", "-help", "--help", help_main)
-            .Default(nullptr);
+    typedef int (*MainFunction)(int, const char *[]);
+    MainFunction Func = StringSwitch<MainFunction>(argv[1])
+                            .Case("convert-for-testing", convertForTestingMain)
+                            .Case("gcov", gcovMain)
+                            .Case("report", reportMain)
+                            .Case("show", showMain)
+                            .Cases("-h", "-help", "--help", helpMain)
+                            .Default(nullptr);
 
-    if (func) {
+    if (Func) {
       std::string Invocation = std::string(argv[0]) + " " + argv[1];
       argv[1] = Invocation.c_str();
-      return func(argc - 1, argv + 1);
+      return Func(argc - 1, argv + 1);
     }
   }
 
@@ -75,5 +74,5 @@ int main(int argc, const char **argv) {
   errs().resetColor();
   errs() << "\n";
 
-  return gcov_main(argc, argv);
+  return gcovMain(argc, argv);
 }





More information about the llvm-commits mailing list