[PATCH] [asan] [mips] added support of asan for mips64/mips64el

Kostya Serebryany kcc at google.com
Thu Oct 30 10:18:42 PDT 2014


================
Comment at: lib/asan/asan_allocator.h:107
@@ -105,1 +106,3 @@
+const uptr kAllocatorSpace = 0x4000000000ULL;
+const uptr kAllocatorSize  = 0x4000000000ULL;  // 256GB.
 # else
----------------
Is this enough? 
As I've asked in http://reviews.llvm.org/D5906, did you verify that this works on
applications that allocate 8Gb of RAM with the same size class? 
Or mips machines are not expected to be used with that much RAM? 
What is the maximal amount of physical RAM in a mips machine for a foreseeable future? 

================
Comment at: lib/sanitizer_common/sanitizer_printf.cc:115
@@ +114,3 @@
+#ifdef __mips__
+  int AddressLength = (SANITIZER_WORDSIZE == 64) ? 10 : 8;
+#else
----------------
I'd like to move this logic to sanitizer_common/sanitizer_platform.h.

Define something like SANITIZER_POINTER_FORMAT_LENGTH there and 
please use FIRST_32_SECOND_64

http://reviews.llvm.org/D6024






More information about the llvm-commits mailing list