[PATCH] Update __dfsw_s{, n}printf custom functions for new calling convention.

Lorenzo Martignoni martignlo at google.com
Thu Oct 30 02:01:34 PDT 2014


LGTM

================
Comment at: lib/dfsan/dfsan_custom.cc:1067
@@ -1073,3 +1066,3 @@
     const Chunk& chunk = chunks[i];
 
     switch (chunk.label_type) {
----------------
The labelling could now be in principle performed right after the formatting. I agree that this can be done later since not urgent. Maybe add a 'TODO(martignlo): ....'?

http://reviews.llvm.org/D6029






More information about the llvm-commits mailing list