[PATCH] [compiler-rt] Use @rpath as LC_ID_DYLIB for ASan dylib on OS X

Alexey Samsonov vonosmas at gmail.com
Wed Oct 29 11:01:47 PDT 2014


================
Comment at: tools/clang/lib/Driver/ToolChains.cpp:313
@@ +312,3 @@
+  if (AddRPath) {
+    assert(DarwinStaticLib.endswith(".dylib") && "must be a dynamic library");
+
----------------
DarwinStaticLib name makes no sense at this point. Consider fixing this in a preliminary commit.

================
Comment at: tools/clang/test/Driver/darwin-asan-rpath.c:1
@@ +1,2 @@
+// RUN: %clang -x c -target x86_64-apple-darwin -fsanitize=address %s -### 2>&1 | FileCheck --check-prefix=CHECK-OSX %s
+// CHECK-OSX: "{{.*}}/lib/darwin/libclang_rt.asan_osx_dynamic.dylib"
----------------
Can you instead fix the existing test for linking ASan runtime on Darwin (if there is any)?

http://reviews.llvm.org/D6018






More information about the llvm-commits mailing list