[PATCH] Update the directive-eabi_attribute tests.

Tim Northover t.p.northover at gmail.com
Wed Oct 29 08:00:38 PDT 2014


Hi Charlie,

A couple of suggestions:

================
Comment at: test/MC/ARM/directive-eabi_attribute-2.s:2-3
@@ -1,2 +1,4 @@
 @ RUN: llvm-mc -triple armv7-elf -filetype asm -o - %s | FileCheck %s
+@ Don't forget to update test/MC/ARM/directive-eabi_attribute.s if you
+@ make changes here.
 
----------------
I think it'd be better to combine these two files, if the input needs to be identical in each. You can run separate commands and use different FileCheck prefixes for the asm vs the text output.

================
Comment at: test/MC/ARM/directive-eabi_attribute.s:13
@@ -10,3 +12,3 @@
 @ <section-length>
-@ CHECK: 250000 00
+@ CHECK: 620000 00
 
----------------
If you can change this without the test breaking, it probably has limited value.

http://reviews.llvm.org/D6021






More information about the llvm-commits mailing list