[llvm] r220710 - Stackmap shadows should consider call returns a branch target.

[Pete Cooper]

Author: pete
Date: Mon Oct 27 14:40:35 2014
New Revision: 220710

URL: http://llvm.org/viewvc/llvm-project?rev=220710&view=rev
Log:
Stackmap shadows should consider call returns a branch target.

To avoid emitting too many nops, a stackmap shadow can include emitted instructions in the shadow, but these must not include branch targets.

A return from a call should count as a branch target as patching over the instructions after the call would lead to incorrect behaviour for threads currently making that call, when they return.

Modified:
    llvm/trunk/lib/Target/X86/X86MCInstLower.cpp
    llvm/trunk/test/CodeGen/X86/stackmap-shadow-optimization.ll

Modified: llvm/trunk/lib/Target/X86/X86MCInstLower.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86MCInstLower.cpp?rev=220710&r1=220709&r2=220710&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86MCInstLower.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86MCInstLower.cpp Mon Oct 27 14:40:35 2014
@@ -1210,4 +1210,10 @@ void X86AsmPrinter::EmitInstruction(cons
   MCInst TmpInst;
   MCInstLowering.Lower(MI, TmpInst);
   EmitAndCountInstruction(TmpInst);
+
+  // Stackmap shadows cannot include branch targets, so we can count the bytes
+  // in a call towards the shadow, but must flush the shadow immediately after
+  // to account for the return from the call.
+  if (MI->isCall())
+    SMShadowTracker.emitShadowPadding(OutStreamer, getSubtargetInfo());
 }

Modified: llvm/trunk/test/CodeGen/X86/stackmap-shadow-optimization.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/stackmap-shadow-optimization.ll?rev=220710&r1=220709&r2=220710&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/stackmap-shadow-optimization.ll (original)
+++ llvm/trunk/test/CodeGen/X86/stackmap-shadow-optimization.ll Mon Oct 27 14:40:35 2014
@@ -1,16 +1,18 @@
 ; RUN: llc < %s -mtriple=x86_64-apple-darwin -mcpu=corei7 | FileCheck %s
 
-; Check that the X86 stackmap shadow optimization is only outputting a 1-byte
-; nop here. 8-bytes are requested, but 7 are covered by the code for the call to
-; bar, the frame teardown and the return.
+; Check that the X86 stackmap shadow optimization is only outputting a 3-byte
+; nop here. 8-bytes are requested, but 5 are covered by the code for the call to
+; bar.  However, the frame teardown and the return do not count towards the
+; stackmap shadow as the call return counts as a branch target so must flush
+; the shadow.
 define void @shadow_optimization_test() {
 entry:
 ; CHECK-LABEL:  shadow_optimization_test:
 ; CHECK:        callq   _bar
 ; CHECK-NOT:    nop
 ; CHECK:        callq   _bar
-; CHECK:        retq
 ; CHECK:        nop
+; CHECK:        retq
   call void @bar()
   tail call void (i64, i32, ...)* @llvm.experimental.stackmap(i64 0, i32 8)
   call void @bar()