[PATCH] [MSan] [MIPS] Adding support for MIPS64

Kostya Serebryany kcc at google.com
Mon Oct 27 11:15:51 PDT 2014


================
Comment at: lib/sanitizer_common/sanitizer_allocator.h:475
@@ +474,3 @@
+  // to have kRegionSize >= 2^32
+  COMPILER_CHECK((kRegionSize) >= (1ULL << (40 / 2)));
+#else
----------------
mohit.bhakkad wrote:
> kcc wrote:
> > Did you already verify that this actually works?
> > For a 40-bit address space you may need to use SanitizerAllocator32 instead. 
> Yes, I have verified using both SanitizerAllocator32 and SanitizerAllocator64, which are giving same results. As SizeClassAllocator64 is more efficient, so we are using that.
How exactly did you verify it? 
Did you run any large programs that consume gigs of RAM? 
I still doubt this will work.

http://reviews.llvm.org/D5906






More information about the llvm-commits mailing list