[PATCH] Enable asan tests on Windows

Aaron Ballman aaron at aaronballman.com
Mon Oct 27 10:20:41 PDT 2014


On Mon, Oct 27, 2014 at 12:55 PM, Timur Iskhodzhanov
<timurrrr at google.com> wrote:
> 2014-10-27 8:57 GMT-07:00 Aaron Ballman <aaron at aaronballman.com>:
>> While trying to fix up cmake issues to get ubsan somewhat stumbling
>> around on Windows, I noticed the reason why all of the asan tests are
>> passing on that platform -- they weren't being run.
>
> That's not true, ASan/Win does have it own tests that are being run.
> [see below though]
>
>> I've attached the logs from my local testing on x86, and it's not
>> pretty. I'm not certain whether we *want* to enable tests on Windows
>> at this point, but if we do, the attached patch ensures the tests run.
>
> Some ASan tests are run and (tests for ''all platforms") are
> intentionally not enabled yet because, well, some of them don't work.
> I had a local patch for a few months that fixes most of them, but
> didn't have cycles to finish it.
>
> I agree this is probably not the easiest thing to figure out on one's
> own – sorry you've spent time on it... Please suggest how to document
> it to avoid doing duplicate work next time?

At this point, the documentation should probably state that
compiler-rt is only usable with an MSVC toolchain by using ninja to
compile an x86, Release configuration. It's unfortunate that
compiler-rt doesn't match the llvm and clang workflows with MSVC.

~Aaron

>
>> Note: the tests still won't run from within MSVC; they only work
>> within Ninja. If someone is better at lit than I (which wouldn't take
>> much), the issue seems to be with an unexpanded variable in the path:
>> lit.py: lit.common.cfg:32: fatal: Can't find compiler on path
>> 'E:/llvm/2013/$(Configuration)/bin/clang.exe'
>>
>> ~Aaron




More information about the llvm-commits mailing list