The linker's PreserveSource mode is broken. Should we fix or delete it?

[Rafael Espíndola]

Forcing PreserveSource causes these tests to fail:

    LLVM :: Linker/metadata-a.ll
    LLVM :: Linker/prefixdata.ll
    LLVM :: Linker/type-unique-odr-a.ll
    LLVM :: Linker/type-unique-simple-a.ll
    LLVM :: Linker/type-unique-simple2-a.ll
    LLVM :: Linker/type-unique-simple2.ll
    LLVM :: Linker/type-unique-type-array-a.ll
    LLVM :: Linker/unnamed-addr1-a.ll
    LLVM :: Linker/visibility1.ll

It is sure to become even worse as new features are added and not
tested in that mode.

The attached patch simply deletes the feature. If it is still needed I
can try to figure out what is broken, add a -preserve-source option to
llvm-link and use it in the tests to make sure it keeps working.

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: text/x-patch
Size: 8893 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141026/d04a48d9/attachment.bin>