[PATCH] UBSan on Windows

Timur Iskhodzhanov timurrrr at google.com
Fri Oct 24 10:14:16 PDT 2014


Hi Aaron,

See also http://reviews.llvm.org/D5368 – Amine has made some progress
on UBSan lately as well, but didn't quite finish it.

Can you please send the review via phab?

Comments:
* Your implementation of atomic_exchange doesn't seem to be atomic?
* lib/ubsan/ubsan_value.h – please update the comment
* Does check-ubsan (?) work?
* Have you tried Win64?

––
Tim

2014-10-24 9:27 GMT-07:00 Aaron Ballman <aaron at aaronballman.com>:
> It turns out that some parts of UBSan seem to be working on Windows.
> This small patch enables Windows support, and gets the UBSan project
> to compile within MSVC. My testing hasn't been particularly thorough
> -- I was wondering if there was a work list of things that need
> porting, since I assume there was a reason this wasn't supported on
> Windows.
>
> With this patch, I was able to compile ubsan within MSVC, and run a
> simple test on things like integer division by zero, and out of bounds
> shifts, etc.
>
> Thanks!
>
> ~Aaron




More information about the llvm-commits mailing list