[PATCH] [mips][microMIPS] Implement CodeGen support for SLL16 and SRL16 instructions

Sasa Stankovic Sasa.Stankovic at imgtec.com
Thu Oct 23 06:34:33 PDT 2014


================
Comment at: lib/Target/Mips/MipsInstrInfo.td:1102
@@ -1101,2 +1101,3 @@
 
 /// Shift Instructions
+let AdditionalPredicates = [NotInMicroMips, HasStdEnc] in {
----------------
You don't need HasStdEnc here, because parent class InstSE sets it.

================
Comment at: test/CodeGen/Mips/micromips-srl.ll:1
@@ +1,2 @@
+; RUN: llc -march=mipsel -mcpu=mips32r2 -mattr=+micromips \
+; RUN:   -relocation-model=pic -O3 < %s | FileCheck %s
----------------
I think it would be better if you merge this file with the test/CodeGen/Mips/micromips-sll.ll, and name the resulting file (for example) test/CodeGen/Mips/micromips-shift.ll.

http://reviews.llvm.org/D5933






More information about the llvm-commits mailing list