[PATCH] [MC] Attach labels to existing fragments instead of using a separate fragment

Eli Bendersky eliben at google.com
Wed Oct 22 14:22:55 PDT 2014


LGTM with some nits

================
Comment at: lib/MC/MCObjectStreamer.cpp:45
@@ -44,1 +44,3 @@
 
+// If any labels have been emitted but not assigned fragments, ensure that they
+// get assigned, either to F if possible or to a new data fragment.
----------------
This comment probably belongs in the header?

================
Comment at: lib/MC/MCObjectStreamer.cpp:153
@@ +152,3 @@
+  // next fragment.
+  MCDataFragment *F = dyn_cast_or_null<MCDataFragment>(getCurrentFragment());
+  if (F) {
----------------
Can merge the dyn cast into the if here?

http://reviews.llvm.org/D5915






More information about the llvm-commits mailing list