[llvm] r220410 - Do not add -gsplit-dwarf to LLVM_DEFINITIONS.

Peter Collingbourne peter at pcc.me.uk
Wed Oct 22 12:49:19 PDT 2014


Author: pcc
Date: Wed Oct 22 14:49:19 2014
New Revision: 220410

URL: http://llvm.org/viewvc/llvm-project?rev=220410&view=rev
Log:
Do not add -gsplit-dwarf to LLVM_DEFINITIONS.

This would cause the flag to appear in the output of "llvm-config --cppflags",
which should contain only preprocessor flags. The -gsplit-dwarf flag in
particular can cause problems with certain downstream users such as cgo.

Differential Revision: http://reviews.llvm.org/D5895

Modified:
    llvm/trunk/cmake/modules/HandleLLVMOptions.cmake

Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=220410&r1=220409&r2=220410&view=diff
==============================================================================
--- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)
+++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Wed Oct 22 14:49:19 2014
@@ -393,7 +393,7 @@ endif()
 
 # Turn on -gsplit-dwarf if requested
 if(LLVM_USE_SPLIT_DWARF)
-  add_llvm_definitions("-gsplit-dwarf")
+  add_definitions("-gsplit-dwarf")
 endif()
 
 add_llvm_definitions( -D__STDC_CONSTANT_MACROS )





More information about the llvm-commits mailing list