[PATCH] Modernize doxygen comments in Support/Dwarf.h

Frederic Riss friss at apple.com
Wed Oct 22 12:00:44 PDT 2014


Hi rafael, dblaikie, echristo,

In post-review of r219442, Rafael pointed out that the comment style of the
newly introduced helper didn't follow LLVM's coding standard. I wanted to
mordernize the whole file, but it seemed too silly to document each of these
simple self-describing functions with the same sentence except for 1 word.
I'm wondering if it's OK to use doxygen's group feature like in the attached
patch, or if repeating "\brief Returns the string for the xxxx parameter of
nullptr if not found." is prefered.

http://reviews.llvm.org/D5918

Files:
  include/llvm/Support/Dwarf.h
  lib/Support/Dwarf.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5918.15268.patch
Type: text/x-patch
Size: 13154 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141022/078dd5a5/attachment.bin>


More information about the llvm-commits mailing list