[PATCH] Change the RegionSet type to a SetVector

Tobias Grosser tobias at grosser.es
Wed Oct 22 01:44:20 PDT 2014


On 22.10.2014 02:17, David Peixotto wrote:
> Hi grosser, jdoerfert, sebpop,
>
> This patch changes the RegionSet type used in ScopDetection from a
> std::set to a llvm::SetVector. The reason for the change is to
> ensure deterministic output when printing the result of the
> analysis. We had a windows buildbot failure for the modified test
> because the output was coming in a different order.
>
> Only one test case needed to be modified for this change. We could
> use CHECK-DAG directives instead of CHECK in the analysis test cases
> because the actual order of scops does not matter, but I think that
> change should be done in a separate patch that modifies all the
> appliciable tests. I simply modified the test to reflect the
> expected deterministic output.
>
> http://reviews.llvm.org/D5897

LGTM.

Thanks,
Tobias



More information about the llvm-commits mailing list