[PATCH] [PowerPC] Support select-cc for VSX

hfinkel at anl.gov hfinkel at anl.gov
Tue Oct 21 12:47:58 PDT 2014


LGTM, thanks!

> One question is	whether we want to add similar code for the VSFRC register class. We currently have _F8 variants of these pseudos to support the f64 type. We could	add _VSFRC variants that override these in PPCInstrVSX.td. It's not a priori clear to me whether this would be helpful; there	may be random effects of introducing copies between the F8RC and VFRC registers, but obviously the benefit is to allow RA to use all 64 scalar float regs. Thoughts?

Yes, I think this sounds like a good idea. I don't think it will introduce any *more* copying than any of the other patterns already do, and reducing register pressure is normally a win.

http://reviews.llvm.org/D5886






More information about the llvm-commits mailing list