[lld] r220185 - [ELF] Add demangle test to XFAIL

Rui Ueyama ruiu at google.com
Tue Oct 21 12:13:11 PDT 2014


On Tue, Oct 21, 2014 at 11:56 AM, Ed Maste <emaste at freebsd.org> wrote:

> On 21 October 2014 14:23, Rui Ueyama <ruiu at google.com> wrote:
> > No strong preference, but it seems XFAIL is tend to be forgotten.
> Compared
> > to that C++ files are maintained well. So if we can fix this in C++ with
> a
> > TODO, it's better to do that instead of adding a XFAIL to a failing test.
>
> Note that the cmake HAVE_CXXABI_H test fails on FreeBSD because of
> this, so that would need to be addressed first.
>

It feels to me that HAVE_CXXABI_H is defined properly in a sense because on
FreeBSD the header is not actually usable unless you include other header
beforehand. Other systems don't have such issue.

I suspect that one of the includes already in
> lib/ReaderWriter/ELF/ELFLinkingContext.cpp will bring in the size_t
> typedef and so it wouldn't need to be changed.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141021/9a0f7d17/attachment.html>


More information about the llvm-commits mailing list