[llvm] r219135 - [BasicAA] Revert "Revert r218714 - Make better use of zext and sign information."

Nicholas White n.j.white at gmail.com
Mon Oct 20 11:46:30 PDT 2014


> I don't understand. If AllPositive becomes false, then we don't return
NoAlias later; why does it matter if we do the remaining checks --
AllPositive will remain false once it has been set to false, right?

That's true - I just wanted to make sure that if anyone introduced more
alias-guessing logic just before the final "return PartialAlias" they
wouldn't introduce a subtle bug. I could just mention this in a comment
there though? Thanks -

Nick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141020/c09600de/attachment.html>


More information about the llvm-commits mailing list