[PATCH] [lld] Teach LLD how to parse complete linker scripts

Shankar Kalpathi Easwaran shankarke at gmail.com
Fri Oct 17 19:29:47 PDT 2014


Could you add test cases that test for invalid linker scripts as well ?

================
Comment at: lib/ReaderWriter/LinkerScript.cpp:977-979
@@ +976,5 @@
+const Expression *Parser::parseExprTerminal() {
+  assert((_tok._kind == Token::identifier || _tok._kind == Token::number ||
+          _tok._kind == Token::kw_align || _tok._kind == Token::l_paren) &&
+         "Expected symbol or number!");
+
----------------
can you convert the assert messages to appropriate error messages that can be displayed to the user ?

http://reviews.llvm.org/D5852






More information about the llvm-commits mailing list