[PATCH] Adding simple disassembler.

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Fri Oct 17 15:13:02 PDT 2014


Thanks a lot for working on this!

================
Comment at: lib/Target/Hexagon/Disassembler/HexagonDisassembler.cpp:38
@@ +37,3 @@
+namespace {
+/// HexagonDisassembler - Hexagon disassembler for all Hexagon platforms.
+class HexagonDisassembler : public MCDisassembler {
----------------
Don't repeat the name int the comment.

================
Comment at: lib/Target/Hexagon/Disassembler/HexagonDisassembler.cpp:45
@@ +44,3 @@
+
+  /// getInstruction - See MCDisassembler.
+  DecodeStatus getInstruction(MCInst &instr, uint64_t &size,
----------------
Don't repeat the name in the comment.

================
Comment at: lib/Target/Hexagon/Disassembler/HexagonDisassembler.cpp:48
@@ +47,3 @@
+                              MemoryObject const &region, uint64_t address,
+                              raw_ostream &vStream, raw_ostream &cStream) const;
+};
----------------
Missing override.

================
Comment at: lib/Target/Hexagon/Disassembler/HexagonDisassembler.cpp:70
@@ +69,3 @@
+
+static DecodeStatus DecodeIntRegsRegisterClass(MCInst &Inst, unsigned RegNo,
+                                               uint64_t /*Address*/,
----------------
Start function names in lowercase.

http://reviews.llvm.org/D5829






More information about the llvm-commits mailing list