[compiler-rt] r219827 - [compiler-rt] Enable ASAN for powerpc64le-linux

Will Schmidt will_schmidt at vnet.ibm.com
Fri Oct 17 07:56:56 PDT 2014


On Wed, 2014-10-15 at 21:53 +0200, Ulrich Weigand wrote:
> Will Schmidt wrote:
> 
> > -#ifdef __powerpc64__
> > -  // On PowerPC64, the address of a function actually points to a
> > +#if defined(__powerpc64__) and defined(__BIG_ENDIAN__)
> > +  // On PowerPC64 ELFv1, the address of a function actually points to a
> 
> It would be better to use a _CALL_ELF != 2 check instead of __BIG_ENDIAN__;
> it is possible (though uncommon) to use ELFv2 on BE or ELFv1 on LE.

Hi Uli, 
  Noted, thanks. :-)   I'll incorporate into a follow-up patch.  

Thanks, 
-Will

> 
> Bye,
> Ulrich
> 





More information about the llvm-commits mailing list