[PATCH] Enable the instruction printer in HexagonMCTargetDesc

Sid Manning sidneym at codeaurora.org
Fri Oct 17 06:09:04 PDT 2014


================
Comment at: lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp:56-57
@@ +55,4 @@
+    return ~(-1U << (bits - 1));
+  else
+    return ~(-1U << bits);
+}
----------------
shankarke wrote:
> same as above comment.
OK, will remove both.

================
Comment at: lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp:159
@@ +158,3 @@
+
+  assert((isExtendable(MII.TSFlags) || isExtended(MII.TSFlags)) &&
+         "Expecting an extendable operand");
----------------
rafael wrote:
> Are this changes intended? The description doesn't mention them.
While troublesome, the assert is intended to keep this routine from being attached to an incorrect insn.

The code below is the fix for the actual dependency.  isConstExtended is in LLVMHexagonDesc, when the inst printer is registered in that library a circular dependency is formed.

http://reviews.llvm.org/D5734






More information about the llvm-commits mailing list