[llvm] r219442 - Add ApplePropertyString dump helper to Dwarf.{h|cpp}.

Frédéric Riss friss at apple.com
Thu Oct 16 16:07:20 PDT 2014


> On 16 Oct 2014, at 13:41, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> 
>> +/// ApplePropertyString - Return the string for the specified Apple
>> +/// property bit. This function is meant to return the symbolic name
>> +/// for 1 bit of the DW_AT_APPLE_property attribute, not for the whole attribute.
>> +const char *ApplePropertyString(unsigned);
> 
> Please don't duplicate the name in the comment.
> 
>> +/// ApplePropertyString - Return the string for the specified Apple
>> +/// property bit. This function is meant to return the symbolic name
>> +/// for 1 bit of the DW_AT_APPLE_property attribute, not for the whole attribute.
>> +const char *llvm::dwarf::ApplePropertyString(unsigned Prop) {
> 
> Or the entire comment in the .cpp.

I just followed the style of the surrounding code. I thought this was the rule. I’ll try to cook up a cleanup patch that updates the comment style of these 2 files.

Fred



More information about the llvm-commits mailing list