[PATCH] [lld] [mach-o] make lld respect alignment constraints more

Tim Northover t.p.northover at gmail.com
Thu Oct 16 13:44:15 PDT 2014


I definitely think it's neater with the explicit ulittle32_t in the individual archhandlers; shame we can't do something similar in the generic code.

I also checked speed on check-lld. The difference (if there was one) seemed to be well within the noise limits.

Does it look better to you too?

Cheers.

Tim.

http://reviews.llvm.org/D5811

Files:
  lib/ReaderWriter/MachO/ArchHandler.cpp
  lib/ReaderWriter/MachO/ArchHandler.h
  lib/ReaderWriter/MachO/ArchHandler_arm.cpp
  lib/ReaderWriter/MachO/ArchHandler_arm64.cpp
  lib/ReaderWriter/MachO/ArchHandler_x86.cpp
  lib/ReaderWriter/MachO/ArchHandler_x86_64.cpp
  lib/ReaderWriter/MachO/CompactUnwindPass.cpp
  lib/ReaderWriter/MachO/MachONormalizedFileBinaryReader.cpp
  lib/ReaderWriter/MachO/MachONormalizedFileBinaryUtils.h
  lib/ReaderWriter/MachO/MachONormalizedFileToAtoms.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5811.15044.patch
Type: text/x-patch
Size: 78741 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141016/7ad33815/attachment.bin>


More information about the llvm-commits mailing list