[PATCH] First stage of call lowering for Mips fast-isel

reed kotler rkotler at mips.com
Wed Oct 15 17:54:23 PDT 2014


There is a pair of C programs as an attachment.
They are an executable test case.

I'm working on converting one the C programs to a make check test right now.
Hopefully tomorrow I will be ready to push it.

It's an extensive abi test for functions that pass all their arguments 
in registers, which
is the extent of the first call lowering putbakc.

On 10/15/2014 05:40 PM, Eric Christopher wrote:
> There's no testcase showing up in this diff at all FWIW.
>
> ================
> Comment at: lib/Target/Mips/MipsFastISel.cpp:183
> @@ +182,3 @@
> +
> +bool (*UnusedMipsFastISel1)(unsigned int, llvm::MVT, llvm::MVT,
> +                            CCValAssign::LocInfo, ISD::ArgFlagsTy,
> ----------------
> rkotler wrote:
>> echristo wrote:
>>> Eh? What's with all of these?
>> I have a patch that fixes that with function attributes as in:
>>
>>      static bool CC_Mips16RetHelper(unsigned ValNo, MVT ValVT,
>>                         MVT LocVT, CCValAssign::LocInfo LocInfo,
>>                         ISD::ArgFlagsTy ArgFlags, CCState &State)
>>      __attribute__((unused));
>>
>>
> Best to just leave them out for now.
>
> http://reviews.llvm.org/D5714
>
>




More information about the llvm-commits mailing list