[PATCH] fix bug where sys::Wait could wait on wrong pid

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Oct 14 10:07:01 PDT 2014


LGTM. Do you have commit access?

On 15 September 2014 13:55, Daniel Reynaud <dreynaud at apple.com> wrote:
> Ping.
>
> On Sep 5, 2014, at 10:15 AM, Daniel Reynaud <dreynaud at apple.com> wrote:
>
>> I see no reason to set ChildPid to -1 when WaitUntilTerminates is true.
>>
>> If there was some other unwaited-for child process that terminates before PI.Pid, its pid would be returned instead of PI.Pid so the function would return "Error waiting for child process", even though errno is 0.
>>
>> By making we wait on the right process, this works as expected.
>>
>>
>> <waitpid.diff>_______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list