[PATCH] [Polly][Unfinished][NFC] Restructure the command line options

Andreas Simbuerger simbuerg at fim.uni-passau.de
Mon Oct 13 23:05:42 PDT 2014


This is exactly what I feared.
I'm not sure if I'm the only one, but I really like the definition of the command-line options where they matter: In the file where they influence something. Why would we want to extract the definitions too? Isn't it sufficient to provide the Options.h header and be done with it (+unify the naming)?

Furthermore this adds maintenance overhead: The description the end-user gets should be enough to understand what the option does. So reading the cl::desc field of a definition should suffice to understand what the option will do. Now you have to keep the comment synchronized to the description (nobody will do that ;-)).

Maybe I'm old, but the only benefits I see here are the external linkage via Options.h and the consistent naming, no need for relocating the definitions too.

http://reviews.llvm.org/D5762






More information about the llvm-commits mailing list