[PATCH] Fix for Bug 5053

Swaroop Sridhar Swaroop.Sridhar at microsoft.com
Mon Oct 13 17:40:17 PDT 2014


Addressed Code review feedback from Reid. Updated the diff in the revision, instead of attaching a patch in my earlier comment.
[Changes are 
1.I'm using VS2013, LLVM 3.5, and not using MCJIT to repro this failure.
2.I've updated the test case to look like the actual test reported in Bug 5053. The problem should repro now, can you please try again?
3.I've fixed the issues you've identified. -> Fixed the wording in the comments for the test case -> Made copysignf VS2013 only
4.In DynamicLibrary.inc, I've simplified the implementation of the inline_ *() functions. Now, inline_fmodf(x,y) simply calls fmodf(x,y) instead of performing (float)fmod(x,y)]

http://reviews.llvm.org/D5387

Files:
  lib/Support/Windows/DynamicLibrary.inc
  lib/Support/Windows/explicit_symbols.inc
  test/ExecutionEngine/win-frem.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5387.14845.patch
Type: text/x-patch
Size: 4332 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141014/8be9ff07/attachment.bin>


More information about the llvm-commits mailing list