[PATCH] Removing the static destructor from ManagedStatic.cpp by controlling the allocation and de-allocaation of the mutex.

Chandler Carruth chandlerc at gmail.com
Mon Oct 13 15:47:53 PDT 2014


================
Comment at: include/llvm/Support/Threading.h:41
@@ +40,3 @@
+
+template <void (*UserFn)(void)> void llvm_call_once() {
+
----------------
You really need some documentation for how to use this correctly...

================
Comment at: include/llvm/Support/Threading.h:42
@@ +41,3 @@
+template <void (*UserFn)(void)> void llvm_call_once() {
+
+#if !defined(__MINGW__)
----------------
I would remove the extraneous blank lines here.

http://reviews.llvm.org/D5473






More information about the llvm-commits mailing list